Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller/improvements and tests #166

Closed
wants to merge 4 commits into from
Closed

Controller/improvements and tests #166

wants to merge 4 commits into from

Commits on Dec 15, 2023

  1. Return a more explicit running status from the controller

    @NelsonVides
    NelsonVides committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9666e2d View commit details
    Browse the repository at this point in the history

  2. Optimise user supervision 

    In the original implementation, the process is monitored by two supervisors, the
original amoc_users_sup, and the amoc_controller one. But this means that bursts
of ups and downs overflow the mailbox of _two_ processes, one of them being
actually the very critical controller.

With this reimplementation, only the amoc_users_sup tracks the processes, and
all requests from the controller are asynchronous. This ensures the controller
does not get blocked and can remain responsive to control requests.
    @NelsonVides
    NelsonVides committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ba8bd93 View commit details
    Browse the repository at this point in the history

  3. Renaming var names to avoid collisions

    @NelsonVides
    NelsonVides committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    4243091 View commit details
    Browse the repository at this point in the history

  4. Add tests for amoc_controller

    @NelsonVides
    NelsonVides committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    53c1795 View commit details
    Browse the repository at this point in the history