You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now there are not validations, so passing bad arguments results in crash of client process in most cases. We could also look into narrowing the scope of Client.ip, or create the new type for IPv4 addresses, because we don't support IPv6 TURN extension (yet?).
The text was updated successfully, but these errors were encountered:
The distinction between IPv4 and IPv6 is never going to disappear, so it's OK to resemble that in the types we use and specify which functions can operate on both (probably public / closer to the public interface) and which are specific to one of them (the underpinnings of the interface).
Regarding prioritisation, IMO specific types (visible in the function signatures) and crashes on misuse are good enough, while validation is nice, of course, but not strictly necessary.
Right now there are not validations, so passing bad arguments results in crash of client process in most cases. We could also look into narrowing the scope of
Client.ip
, or create the new type for IPv4 addresses, because we don't support IPv6 TURN extension (yet?).The text was updated successfully, but these errors were encountered: