Receiving data coming over relay #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 24, 2017 10:42
erszcz
approved these changes
Apr 24, 2017
lib/jerboa/client/worker.ex
Outdated
|
|
||
| @spec update_subscriber_ref(subscribers, pid, reference) :: subscribers | ||
| defp update_subscriber_ref(subscribers, sub_pid, sub_ref) do | ||
| if Map.has_key?(subscribers, sub_pid) do |
There was a problem hiding this comment.
Map.has_key? followed by Map.get - we traverse the map twice, while Map.fetch/Map.get_and_update would do the job by traversing just once. Not a big deal (before we load test), but not complex to fix either.
lib/jerboa/client.ex
Outdated
| Subscribes PID to data received from the given peer | ||
|
|
||
| Message format is | ||
| {:peer_data, client_pid :: pid,peer :: address, data :: binary} |
lib/jerboa/client.ex
Outdated
| Subscribes calling process to data received from the given peer | ||
|
|
||
| Message format is | ||
| {:peer_data, client_pid :: pid,peer :: address, data :: binary} |
|
All green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative implementation of #95.
Instead of installing handler functions in the client process, processes can subscribe to data sent by specified peers. This way we have even more generic behaviour plus we can easily track subscribers and clean up state related to them when they die.