Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [file-extension-in-import] False positive with zx #131

Closed
1 task
Zamiell opened this issue Oct 25, 2023 · 2 comments
Closed
1 task

Bug: [file-extension-in-import] False positive with zx #131

Zamiell opened this issue Oct 25, 2023 · 2 comments
Labels

Comments

@Zamiell
Copy link

Zamiell commented Oct 25, 2023

Environment

Consider zx, which is a Node.js library by Google to write scripts.

You use it by just adding this to the top of your JavaScript/TypeScript file:

import "zx/globals";

However, this line triggers the file-extension-in-import rule. I think that this rule is intended to apply to files in your local project, not to imports from 3rd-party packages. So, I think this is a false positive.

In the meantime before this bug is fixed, does anyone know if there is some way to use the rule options to work around this?

Participation

  • I am willing to submit a pull request for this issue.
@Zamiell Zamiell added the bug label Oct 25, 2023
@Zamiell Zamiell changed the title Bug: False positive with zx Bug: [file-extension-in-import] False positive with zx Oct 25, 2023
@scagood
Copy link

scagood commented Oct 25, 2023

I think this is a duplicate of #21.
I remember seeing #32 to fix that.

@Zamiell
Copy link
Author

Zamiell commented Oct 25, 2023

@scagood Thank you! That's fantastic, it looks like #32 takes care of it.
Looks like the PR has been sitting since August though. @aladdin-add Can you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants