Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

> > @xjamundx what can we do to help to get this merged? #266

Closed
Sandesh333333 opened this issue Jan 29, 2022 · 1 comment
Closed

> > @xjamundx what can we do to help to get this merged? #266

Sandesh333333 opened this issue Jan 29, 2022 · 1 comment

Comments

@Sandesh333333
Copy link

@xjamundx what can we do to help to get this merged?

I think we could break apart the needed changes into individual issues and PR:s which can more easily be reviewed and discussed rather than this large one which changes 18 files and has discussions all over the place.

Generally: The smaller change, the easier the merge and the more focused discussions and reviews.

I generally agree on this, but 90% of the changed files only include schema: [],, so it should be pretty easy to review...

Originally posted by @marcoreni in #219 (comment)
@xjamundx
Copy link
Contributor

I don't understand this post, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xjamundx @Sandesh333333