Meta type #185
Merged
Meta type #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance y'all can take a look? Thanks... |
|
Will try to look this weekend or on Monday. Appreciate it
…On Fri, May 15, 2020 at 8:21 PM Brett Zamir ***@***.***> wrote:
Any chance y'all can take a look? Thanks...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#185 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4C7YSDDNNZRBKMBZBE3LRRYBERANCNFSM4MF6MCUQ>
.
|
|
What, no firm promises from the promise plugin? ;-) JK of course... Thanks! |
|
I'm basically fine with this change, but not really in love with the formatting change (specifically adding trailing commas). If you want to introduce another PR where you bring in prettier that would be fine, but otherwise I'd prefer if you could remove that change and then I'll be fine with merging. |
|
I guess you mean I could add a separate PR to update Prettier (which starts requiring trailing commas) along with the corresponding linting changes? (Just wanted to be sure you were aware an earlier version of Prettier was already in force.) |
Can use `eslint --fix-type` with meta.type (see https://eslint.org/docs/user-guide/command-line-interface#fix-type )
This was referenced May 19, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
meta.typeto all rulesCan use
eslint --fix-typewith meta.type (see https://eslint.org/docs/user-guide/command-line-interface#fix-type )(I'm also working on an eslint badge formatter which allows categorizing rule violations by
meta.type(i.e., problem, layout, or suggestion), so having this fixed would allow it to be properly categorized.)