Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm linting #184

Merged
merged 2 commits into from Feb 10, 2021
Merged

Npm linting #184

merged 2 commits into from Feb 10, 2021

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Apr 11, 2020

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain: Chores (though package.json properties also useful on npmjs.com)

What changes did you make? (Give an overview)

Builds on #183. This now builds on #191 . This now builds on #195

  • Linting: As per latest prettier
  • npm: Update prettier-related devDeps.
  • Testing: Fix test expectation broken on master

@brettz9 brettz9 mentioned this pull request Apr 11, 2020
6 tasks
@brettz9 brettz9 force-pushed the npm-linting branch 2 times, most recently from 890dccf to c69ec50 Compare May 19, 2020 08:16
@brettz9
Copy link
Contributor Author

brettz9 commented May 19, 2020

I've changed this as discussed in #185 . Now builds on #191 (which adds non-prettier npm changes) and this now just adds the following on top:

  • Linting: As per latest prettier
  • npm: Update prettier-related devDeps.

@brettz9 brettz9 mentioned this pull request May 19, 2020
Merged
6 tasks
- Testing: Fix test (was not parsing)
- Testing: Fix test (missing an error message)
@brettz9
Copy link
Contributor Author

brettz9 commented Jul 23, 2020

Note that in this PR, besides the stylistic changes, I added one message to an invalid test in __tests__/prefer-await-to-then.js as it should now expect three errors, not two (i.e., report the catch also as per the changes in 6378bb9 ).

That is the reason this is based on master instead of development, because development hasn't yet merged the master changes, but it is necessary to fix that test in master regardless.

@brettz9
Copy link
Contributor Author

brettz9 commented Jul 23, 2020

Because of the need to fix the issue just mentioned which I've already filed in #195, I've rebased this PR on top of #195. I therefore think you'll want to review that one first, as your master is broken without it. Thanks!

@xjamundx xjamundx merged commit b38f14c into eslint-community:master Feb 10, 2021
@brettz9 brettz9 deleted the npm-linting branch February 11, 2021 06:48
@brettz9 brettz9 mentioned this pull request Apr 9, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants