Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
The need for these changes was introduced in 6378bb9
I might suggest enabling Travis on PRs: https://github.com/apps/travis-ci so as to be able to catch test and linting regressions before PRs are merged.
While the linting fix and one of the test fixes were clear as to resolution, in the case of:
I had two reasons for my changes:
try
cannot be within()
, as it requires an expression, andtry
is a statement.(error)
), the test would need to be changed to the following (I can change it to this if desired, but didn't want to overcomplicate things if this wasn't needed by the test):I think this should probably be settled before #184 may be assessed (then I can rebase that on this).