Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Broken table of contents links in Node.js API docs #739

Closed
jooohhn opened this issue Jun 12, 2020 · 4 comments
Closed

Broken table of contents links in Node.js API docs #739

jooohhn opened this issue Jun 12, 2020 · 4 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug The site is working incorrectly help wanted The team would welcome a contribution from the community for this issue

Comments

@jooohhn
Copy link

jooohhn commented Jun 12, 2020

The ESLint-related links in the Node.js API table of contents are broken.

Problems:

  • Don't jump to the correct section within the page
    • constructor() -> static static getErrorResults()
  • Lead to a 404
    • LintResult type -> Formatter type

image
@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jun 12, 2020
@kaicataldo kaicataldo added bug The site is working incorrectly accepted There is consensus among the team that this change meets the criteria for inclusion help wanted The team would welcome a contribution from the community for this issue and removed triage An ESLint team member will look at this issue soon labels Jun 12, 2020
@kaicataldo
Copy link
Member

Thanks, I have verified this bug. A PR to fix this would be welcome! For whoever ends up working on this, the file that needs to be changed is here. We copy this file over to this repository when we run a release.

@jooohhn jooohhn mentioned this issue Jun 13, 2020
Closed
1 task
@jooohhn
Copy link
Author

jooohhn commented Jun 13, 2020

I created a PR for this fix in the main repo (eslint/eslint#13415)

@kaicataldo
Copy link
Member

Thank you!

@mdjermanovic
Copy link
Member

This is fixed now, so closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug The site is working incorrectly help wanted The team would welcome a contribution from the community for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kaicataldo @jooohhn @mdjermanovic