Update: enforceForSequenceExpressions to no-extra-parens (fixes #11916) #12142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Changes an existing rule #11916
New
enforceForSequenceExpressions
option inno-extra-parens
, to avoid conflicts withno-sequences
.When this option is set to
false
(default istrue
)no-extra-parens
rule does not report extra parens around sequence expressions.What rule do you want to change?
no-extra-parens
Does this change cause the rule to produce more or fewer warnings?
fewer
How will the change be implemented? (New option, new default behavior, etc.)?
new option
Please provide some example code that this change will affect:
What does the rule currently do for this code?
3 warnings.
What will the rule do after it's changed?
No warnings if the option is set to
false
.What changes did you make? (Give an overview)
New option.
Also, unrelated:
in
in a for-loop init (fixes #11706) #11848 in tests, this was waiting for Fix: fix no-extra-parens ignores some nodes #11909.Is there anything you'd like reviewers to focus on?
Does not account for double parens. I believe that the issue with double parens is not directly related to this option (#12127).