-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: isSpaceBetweenTokens() recognizes spaces in JSXText (fixes #12614) #12616
Conversation
e6de965
to
8e73ee3
Compare
It'd be great if you had the time to verify that eslint-plugin-react's tests pass on master with this change :-) |
I'm sorry, today I failed to get time to follow the review. I will do it tomorrow (JST).
I confirmed it by copying/pasting this patch to |
I have updated this PR. Now, this patch doesn't apply to the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This reverts commit 71c7d01. Thanks to v6.7.2 / eslint/eslint#12616 / eslint/eslint#12614
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #12614
What changes did you make? (Give an overview)
This PR changes
isSpaceBetweenTokens()
method to recognize spaces inJSXText
tokens in order to fix #12614. TheJSXText
tokens include whitespaces such as indentation.Is there anything you'd like reviewers to focus on?