Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: assertions on reporting loc in unicode-bom (refs #12334) #14809

merged 2 commits into from Jul 25, 2021


Copy link

@snitin315 snitin315 commented Jul 18, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

Refs #12334

What changes did you make? (Give an overview)

This PR adds loc.end to reports in unicode-bom rule.

Is there anything you'd like reviewers to focus on?


lib/rules/unicode-bom.js Outdated Show resolved Hide resolved
@snitin315 snitin315 changed the title Update: add end location to report in unicode-bom (refs #12334) Chore: add assertions on reporting location in unicode-bom (refs #12334) Jul 20, 2021
Copy link

@eslint-github-bot eslint-github-bot bot commented Jul 20, 2021

Hi @snitin315!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

@snitin315 snitin315 changed the title Chore: add assertions on reporting location in unicode-bom (refs #12334) Chore: assertions on reporting loc in unicode-bom (refs #12334) Jul 20, 2021
nzakas approved these changes Jul 22, 2021
Copy link

@nzakas nzakas left a comment


Copy link

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit eba0c45 into master Jul 25, 2021
14 checks passed
@mdjermanovic mdjermanovic deleted the update/unicode-bom-loc branch Jul 25, 2021
bmish added a commit to bmish/eslint that referenced this issue Jul 27, 2021
* master:
  Chore: Adopt `eslint-plugin/require-meta-docs-url` rule internally (eslint#14823)
  Docs: New syntax issue template (eslint#14826)
  Chore: assertions on reporting loc in `unicode-bom` (refs eslint#12334) (eslint#14809)
  Docs: fix multiple broken links (eslint#14833)
  Chore: use `actions/setup-node@v2` (eslint#14816)
  Docs: Update README team and sponsors
  Build: changelog update for 7.31.0
  Upgrade: @eslint/eslintrc to v0.4.3 (eslint#14808)
  Update: add end location to report in `consistent-return` (refs eslint#12334) (eslint#14798)
  Docs: update BUG_REPORT template (eslint#14787)
  Docs: provide more context to no-eq-null (eslint#14801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants