Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: use actions/setup-node@v2 #14816

Merged
merged 2 commits into from Jul 22, 2021
Merged

Chore: use actions/setup-node@v2 #14816

merged 2 commits into from Jul 22, 2021

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jul 20, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain: CI related

What changes did you make? (Give an overview)

updated setup-node action to v2 for CI node workflow.

https://github.com/marketplace/actions/setup-node-js-environment

Is there anything you'd like reviewers to focus on?

No

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jul 20, 2021
bmish
bmish approved these changes Jul 20, 2021
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Should we also update line 38, and is there an overview of breaking changes in v2?

@mdjermanovic mdjermanovic added chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jul 20, 2021
@bmish
Copy link
Sponsor Member

bmish commented Jul 20, 2021

I was looking to find out if there were any breaking changes, it's hard to tell but doesn't look like it: https://github.com/actions/setup-node/releases

@mdjermanovic
Copy link
Member

mdjermanovic commented Jul 20, 2021

I found a question about v2 breaking changes (actions/setup-node#223), as it seems that an overview of v2 is missing. By actions/setup-node#223 (comment), it does look like there were no breaking changes.

@snitin315
Copy link
Contributor Author

snitin315 commented Jul 21, 2021

Should we also update line 38, and is there an overview of breaking changes in v2?

Yes, I missed that one. There aren't any breaking changes, we can update safely.

nzakas
nzakas approved these changes Jul 22, 2021
@nzakas nzakas merged commit 60df44c into master Jul 22, 2021
14 checks passed
@nzakas nzakas deleted the ci-setup-node branch Jul 22, 2021
bmish added a commit to bmish/eslint that referenced this pull request Jul 27, 2021
* master:
  Chore: Adopt `eslint-plugin/require-meta-docs-url` rule internally (eslint#14823)
  Docs: New syntax issue template (eslint#14826)
  Chore: assertions on reporting loc in `unicode-bom` (refs eslint#12334) (eslint#14809)
  Docs: fix multiple broken links (eslint#14833)
  Chore: use `actions/setup-node@v2` (eslint#14816)
  Docs: Update README team and sponsors
  7.31.0
  Build: changelog update for 7.31.0
  Upgrade: @eslint/eslintrc to v0.4.3 (eslint#14808)
  Update: add end location to report in `consistent-return` (refs eslint#12334) (eslint#14798)
  Docs: update BUG_REPORT template (eslint#14787)
  Docs: provide more context to no-eq-null (eslint#14801)
aladdin-add added a commit to eslint/eslintrc that referenced this pull request Aug 5, 2021
it's as the same as we have done in the eslint repo: eslint/eslint#14816
aladdin-add added a commit to eslint/espree that referenced this pull request Aug 5, 2021
it's as the same as we have done in the eslint repo: eslint/eslint#14816
aladdin-add added a commit to eslint/eslintrc that referenced this pull request Aug 5, 2021
it's as the same as we have done in the eslint repo: eslint/eslint#14816
brettz9 pushed a commit to eslint/eslintrc that referenced this pull request Aug 5, 2021
aladdin-add added a commit to eslint/espree that referenced this pull request Aug 5, 2021
* Chore: use actions/setup-node@v2

it's as the same as we have done in the eslint repo: eslint/eslint#14816

* Update ci.yml
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 19, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants