Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ESTree default parameters #114

Closed
nzakas opened this issue Mar 28, 2015 · 1 comment
Closed

implement ESTree default parameters #114

nzakas opened this issue Mar 28, 2015 · 1 comment
Labels
accepted enhancement
Milestone
v2.0.0

Comments

@nzakas
Copy link
Member

nzakas commented Mar 28, 2015

ESTree has finalized default parameter syntax that's different from what we have, so we need to update.

The defaults property should be removed and each default param should be represented by an AssignmentPattern (https://github.com/estree/estree/blob/master/es6.md#assignmentpattern)
@nzakas nzakas modified the milestone: v2.0.0 Mar 28, 2015
@nzakas
Copy link
Member Author

nzakas commented Apr 4, 2015

Working on this.

@nzakas nzakas closed this as completed in 9e99a35 Apr 4, 2015
nzakas added a commit that referenced this issue Apr 4, 2015
@nzakas
Merge pull request #120 from eslint/issue114
64a2733 
Breaking: Use ESTree format for default params (fixes #114)
@hegemonic hegemonic mentioned this issue Apr 6, 2015
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted enhancement
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@nzakas