Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rest parameters to implement ESTree #84

Closed
nzakas opened this issue Mar 7, 2015 · 3 comments
Closed

Change rest parameters to implement ESTree #84

nzakas opened this issue Mar 7, 2015 · 3 comments
Labels
accepted enhancement
Milestone
v2.0.0

Comments

@nzakas
Copy link
Member

nzakas commented Mar 7, 2015

Rest parameters should now end up in a RestElement in a function's params array (see https://github.com/estree/estree/blob/master/es6.md#restelement). This would involve removing the rest property from all function types and would be a breaking change.
@xjamundx
Copy link
Contributor

I can maybe take this in a few days if it's not urgent...

@nzakas
Copy link
Member Author

nzakas commented Mar 10, 2015

Not urgent.

@nzakas nzakas mentioned this issue Mar 12, 2015
Open
@nzakas
Copy link
Member Author

nzakas commented Mar 28, 2015

Working on this.

nzakas added a commit that referenced this issue Mar 28, 2015
@nzakas
Breaking: Switch to RestElement for rest args (fixes #84)
ad44df6
@nzakas nzakas modified the milestone: v2.0.0 Mar 28, 2015
@nzakas nzakas closed this as completed in 6cdfc14 Apr 4, 2015
nzakas added a commit that referenced this issue Apr 4, 2015
@nzakas
Merge pull request #113 from eslint/issue84
0193bfe 
Breaking: Switch to RestElement for rest args (fixes #84)
@hegemonic hegemonic mentioned this issue Jun 12, 2015
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted enhancement
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@nzakas @xjamundx