Fix: tokenize the latest right curly brace (fixes #403) #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for contributing. It looks like there are some tests failing - do you mind fixing those so that we can review this? |
|
Hi @kaicataldo , thank you for quick response. |
kaicataldo
reviewed
Jul 31, 2019
|
Hi @finico, would you mind merging/rebasing upstream changes please? Thanks! |
platinumazure
approved these changes
Aug 14, 2019
kaicataldo
approved these changes
Aug 15, 2019
kaicataldo
reviewed
Aug 15, 2019
platinumazure
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
LGTM, thanks so much for contributing! I apologize for any confusion in our review comments as I think I had something slightly different in mind from @kaicataldo 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a logic in
TokenTranslator::onTokenabout the latest curly bracehttps://github.com/eslint/espree/blob/6ebc21947166399a0b4918d4a1beb9d610650336/lib/token-translator.js#L196-L204
But it executes only at first
eoftoken (it seems strange that the first token iseof, but it comes from Acorn's init state)I've added a call of
nextfor theTokenTranslator::onTokento be executed with the lasteoftokenAnd I've noticed two failed tests, but they've already fixed at #416