Breaking: drop Node v8 support #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btmills
approved these changes
Feb 12, 2020
Co-Authored-By: Brandon Mills <btmills@users.noreply.github.com>
btmills
approved these changes
Feb 12, 2020
2 tasks
|
@kaicataldo I noticed few TODOs which were blocking cause of node < 8 . like [ |
|
Do you mind clarifying what you mean? Did you mean to link something? |
|
sorry , forgot to add the link. here is the link |
|
@anikethsaha we can handle that separately as it doesn’t block this PR. |
mysticatea
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Node v8 is no longer being supported (and we're dropping support in ESLint core), it seems prudent to also drop support in Espree.
Questions:
Have I missed anything?