Update: update acorn-jsx and fix failing test #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
commented
Feb 28, 2020
| @@ -1 +1 @@ | |||
| <LeftRight left=<a /> right=<b>monkeys /> gorillas</b> />; | |||
There was a problem hiding this comment.
This is a syntax error in the JSX spec. Please see acornjs/acorn-jsx#106 for more details.
nzakas
approved these changes
Feb 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acorn-jsxreleased v5.2.0, which includes the changes from this PR. Since we have the same test in this repo, tests are failing inmaster. Updating the package.json and tests will ensure that tests pass again.I've labeled this as an "Update" because I believe it should be treated as a semver-minor bug fix, since it is a bug fix that will lead to more errors.
More details can be found here.