Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: acorn to 8.2.2 (fixes #472) #492

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Upgrade: acorn to 8.2.2 (fixes #472) #492

merged 1 commit into from
Apr 30, 2021

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Apr 30, 2021 •
edited
Loading

seems it has been fixed in latest acorn

@nzakas nzakas linked an issue Apr 30, 2021 that may be closed by this pull request
Should throw on async () => await 5 ** 6; #472
Closed
nzakas
nzakas approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

mdjermanovic
mdjermanovic approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 94508b7 into main Apr 30, 2021
@aladdin-add aladdin-add deleted the issue472 branch April 30, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
accepted bug dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should throw on async () => await 5 ** 6;
3 participants
@aladdin-add @nzakas @mdjermanovic