Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add meta info to plugin #12

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: Add meta info to plugin #12

merged 1 commit into from
Jul 22, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 18, 2024

Prerequisites checklist

What is the purpose of this pull request?

Add meta info to the plugin

What changes did you make? (Give an overview)

  • added meta object to the plugin
  • updated release-please-config.json to update src/index.js with the correct version number
  • removed release-as from release-please-config.json

Related Issues

Is there anything you'd like reviewers to focus on?

@nzakas
Copy link
Member Author

nzakas commented Jul 18, 2024

Not sure what the problem is with Node.js v22. Hopefully just a transient.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just waiting for CI to be fixed. Hopefully a patch in Node.js 22.5 will be released soon, otherwise we might want to pin 22.4.

@mdjermanovic
Copy link
Member

Just one more thing - this looks like something we'd want to release, so perhaps it should be tagged as feat?

@nzakas
Copy link
Member Author

nzakas commented Jul 18, 2024

Good call. 👍

@nzakas nzakas changed the title chore: Add meta info to plugin feat: Add meta info to plugin Jul 18, 2024
@mdjermanovic mdjermanovic merged commit f419757 into main Jul 22, 2024
15 checks passed
@mdjermanovic mdjermanovic deleted the meta-info branch July 22, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants