-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aliasing dependencies doesn't affect typescript declaration #102
Comments
@takker99 thanks I will fix this later! |
@ije Can I sponsor (Patreon, Paypal, GH Sponsors, or similar) you in any way to get this fixed? |
@lucacasonato i will fix it very soon, no sponsor needed, thanks for your kind! |
Ran into this issue today, looking forward to the fix. Need to specify ethers 5.4.7 because 5.5.1 has broken types, but this doesn't affect x-typescript-types: |
@ije still seeing this so I'm also wondering if there's any way we can sponsor you for this now. |
Thanks for fixing this so quickly! |
In some packages, aliasing dependencies doesn't affect typescript declaration.
For example, https://esm.sh/use-resize-observer@7.0.1?alias=react:preact&deps=preact@10.5.14 is expected to use https://cdn.esm.sh/v45/deps=preact@10.5.14/preact@10.5.14/src/index.d.ts, but actually uses https://cdn.esm.sh/v45/deps=preact@10.5.14/@types/react@17.0.19/index.d.ts
The text was updated successfully, but these errors were encountered: