Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliasing dependencies doesn't affect typescript declaration #102

Closed
takker99 opened this issue Aug 27, 2021 · 6 comments
Closed

Aliasing dependencies doesn't affect typescript declaration #102

takker99 opened this issue Aug 27, 2021 · 6 comments
Labels
types Types is wrong

Comments

@takker99
Copy link

In some packages, aliasing dependencies doesn't affect typescript declaration.

For example, https://esm.sh/use-resize-observer@7.0.1?alias=react:preact&deps=preact@10.5.14 is expected to use https://cdn.esm.sh/v45/deps=preact@10.5.14/preact@10.5.14/src/index.d.ts, but actually uses https://cdn.esm.sh/v45/deps=preact@10.5.14/@types/react@17.0.19/index.d.ts

@ije
Copy link
Member

ije commented Aug 28, 2021

@takker99 thanks I will fix this later!

@ije ije added the types Types is wrong label Sep 7, 2021
@lucacasonato
Copy link
Contributor

@ije Can I sponsor (Patreon, Paypal, GH Sponsors, or similar) you in any way to get this fixed?

@ije
Copy link
Member

ije commented Sep 24, 2021

@lucacasonato i will fix it very soon, no sponsor needed, thanks for your kind!

@voltrevo
Copy link

voltrevo commented Oct 21, 2021

Ran into this issue today, looking forward to the fix.

Need to specify ethers 5.4.7 because 5.5.1 has broken types, but this doesn't affect x-typescript-types:
https://esm.sh/bls-wallet-clients@0.2.0-rc.1?deps=ethers@5.4.7

@sachinraja
Copy link

@ije still seeing this so I'm also wondering if there's any way we can sponsor you for this now.

@ije ije closed this as completed in 4dadb5f May 21, 2022
@sachinraja
Copy link

Thanks for fixing this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types Types is wrong
Projects
None yet
Development

No branches or pull requests

5 participants