feat(build): add the 'ignore-annotations' option for esbuild #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ije
reviewed
Jun 19, 2022
server/query.go
Outdated
| if endsWith(submodule, ".ia") { | ||
| submodule = strings.TrimSuffix(submodule, ".ia") | ||
| ignoreAnnotations = true | ||
| } | ||
| if endsWith(submodule, ".nr") { |
There was a problem hiding this comment.
here you should trim ".ia" before ".kn"
alienzhou
force-pushed
the
feat/esbuild-ignore-annotations
branch
from
9377e42
to
29427a7
Compare
|
LGTM |
austinhallock
pushed a commit
to trufflehq/esm.sh
that referenced
this pull request
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libs may provide wrong 'side-effect' annotations. As a result, esbuild will remove the side-effect code unexpectedly.
For this reason esbuild provides an option named 'IgnoreAnnotations':
ecomfe/zrender(used by apache/echarts) is a realworld example. Code below was removed unexpectedly:
And I have opened an issue: ecomfe/zrender#927
These packages' newer versions may fix it but the old versions could not work without this option.