ISSUE-26: Add a Cancel Edit button to Webform widget editing #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So this is new and was asked by the cool folks from ESIE (looks at @alliomeria 👀 ). This pull adds dynamically a 'Cancel --some placeholder text you decide on' button when editing an existing object via a webform. Which has two effects. - REmoves the current form and shows back the 'Edit --some placeholder text you decide on' button shows back also the Save Node buttons on top. If feels not fancy but brings also back the 'edit in a pop-up mode' and a more stronger and better code for all of this. That. Late. Last pull for webforms before official beta3. Adios
Still need to address @alliomeria 's comment on collapsing/simply not showing EXIF when having a lot of Images. Will have to think about that since each EXIF really runs in its own process via AJAX so each one does not know how many there are. But i can do this. and its needed. 👀 🏮
DiegoPino
added
bug
And since we depend on webform, let's use the version that Drupal 9 loves too 5.19
This was
linked to
issues
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26
Since 26 is a macro issue, this is just a step forward: This pull adds a Cancel Button to any ADO via a Webform Editing session (editing, not creating from 0) which triggers also Edit Buttons from the main Node Form to be displayed again and the original "Edit SOMEPLACEHOLDER TEXT YOU DECIDED ON" to appear back. Logic is simple and most of that is Ajax Commands being send as response to the existing Model Controller we built back in the days:
Also covers
#56 Drupal 9!
Other Improvements:
@TODO:Expose as an setting to the Widget. So people can decide if they want the inline form (as they get now) or the popup a new one (as they got in 2019)