Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxUtils.unsubscribe vs CompositeSubscription #17

Closed
wotomas opened this issue Jan 25, 2017 · 2 comments
Closed

RxUtils.unsubscribe vs CompositeSubscription #17

wotomas opened this issue Jan 25, 2017 · 2 comments
Labels

Comments

@wotomas
Copy link
Contributor

wotomas commented Jan 25, 2017

I am curious, is there a specific reason why you decided to use

RxUtils.unsubscribe(trailersSubscription, reviewSubscription);

over

CompositeSubscription unsubscribe()

:D just curious!

@esoxjem
Copy link
Owner

esoxjem commented Jan 25, 2017

@wotomas I find creating + adding + unsubscribing from a CompositeSubscription every time a bit cumbersome, something that Uncle Bob calls "Temporal Coupling". Using a utility function seems more succinct.

@wotomas
Copy link
Contributor Author

wotomas commented Jan 25, 2017

I see, it makes sense! thanks!

@esoxjem esoxjem closed this as completed Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants