refactor(Command): Create _onCustom method

esp-admin · Nov 20, 2023 · a3161be · a3161be
1 parent 997bb02
commit a3161be
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 13 deletions.
diff --git a/include/Command.h b/include/Command.h
@@ -28,6 +28,7 @@ namespace ESPAdmin
         static void _onConfig(const String &message);
         static void _onRestart();
         static void _onLog(const String &message);
+        static void _onCustom(const String &message);
     };
 }
 

diff --git a/src/Command.cpp b/src/Command.cpp
@@ -32,14 +32,7 @@ namespace ESPAdmin
 
         else if (type == "custom")
         {
-            if (onCustom == nullptr)
-            {
-                _logger.warn("no handler registered for custom commands");
-            }
-            else
-            {
-                onCustom(message);
-            }
+            _onCustom(message);
         }
     }
 
@@ -65,12 +58,9 @@ namespace ESPAdmin
     {
         Store::set(STORE_CONFIG, message.c_str());
 
-        if (onConfig == nullptr)
-        {
-            _logger.warn("no handler registered for config command");
-        }
-        else
+        if (onConfig != nullptr)
         {
+
             onConfig(Store::get(STORE_CONFIG));
         }
     }
@@ -89,4 +79,16 @@ namespace ESPAdmin
     {
         Store::logRemoteEnabled = message == "on" ? true : false;
     }
+
+    void Command::_onCustom(const String &message)
+    {
+        if (onCustom == nullptr)
+        {
+            _logger.warn("no handler registered for custom commands");
+        }
+        else
+        {
+            onCustom(message);
+        }
+    }
 }