Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-println: Add auto-detect feature #1576

Closed
MabezDev opened this issue Apr 7, 2024 · 1 comment · Fixed by #1658
Closed

esp-println: Add auto-detect feature #1576

MabezDev opened this issue Apr 7, 2024 · 1 comment · Fixed by #1658
Assignees
Labels
package:esp-println Issues related to the esp-println package status:needs-attention This should be prioritized

Comments

@MabezDev
Copy link
Member

MabezDev commented Apr 7, 2024

In the flasher stub we have some code to detect (from ROM code) which transport method is connected: https://github.com/esp-rs/esp-flasher-stub/blob/e9b61293aa181a6ef8ffb326ce4360cf2f1162c3/src/lib.rs#L43-L77.

Maybe we can adapt this to use in esp-println, so that no output method feature is required. It might help in cases such as esp-rs/esp-wifi-sys#452.

One thing I'm not so sure about is when this detection should occur, I think my initial instinct would be to make it lazy and check on first access and then keep using that method until reset.

@bjoernQ
Copy link
Contributor

bjoernQ commented Apr 7, 2024

Good idea. Should probably be a new default feature since detecting it at runtime would require to have code for both in the resulting binary - not a lot of code however

@MabezDev MabezDev transferred this issue from esp-rs/esp-println May 23, 2024
@jessebraham jessebraham changed the title Add auto-detect feature esp-println: Add auto-detect feature May 23, 2024
@jessebraham jessebraham added package:esp-println Issues related to the esp-println package and removed enhancement labels May 23, 2024
@MabezDev MabezDev added the status:needs-attention This should be prioritized label May 29, 2024
@bjoernQ bjoernQ self-assigned this Jun 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:esp-println Issues related to the esp-println package status:needs-attention This should be prioritized
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants