Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic automated tests #339

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add basic automated tests #339

merged 1 commit into from
Nov 7, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Nov 7, 2023

This just adds some very basic automated tests to be run locally. It's basically an automated version of smoketest.bat which I use to verify things still work - but the manual process takes > 1h so this should help a little bit.

The test runner could use some improvements but I now have a first version which is apparently useful and worth to evaluate. The current set of tests only test the non-async code and basically adaptions of the existing examples - I will add more tests when I get to that

Long-term goal is to unify the tests here and the HIL testing we will have in esp-hal one day. Maybe even running the tests during CI - but for now, this is better than having nothing

In any way this shouldn't annoy most users - the only file this messes with is the examples section in Cargo.toml which shouldn't be a big problem. Last not least I will maintain the tests myself so no problem for future contributors

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe in the future we can replace the .bat with an xtask command so unix folks can run it too, but given that you're doing most of the testing you're the priority at the moment :D.

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Nov 7, 2023

Good idea to use an xtask - was thinking about a justfile otherwise but the .bat was the fasted thing. Thanks

@bjoernQ bjoernQ merged commit 69ed065 into main Nov 7, 2023
7 checks passed
@bjoernQ bjoernQ deleted the some-test-automation branch November 7, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants