-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESP32-C3 development mode #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a small fix to the delay impl
May I ask why |
Still working in
|
Seems it ran out of memory (malloc got a null pointer) - interesting |
I have no idea - doesn't make any sense at all |
@jessebraham maybe 2df9af7 can prevent that crash you are seeing - in any case it's the right thing to do in code |
I no longer get an exception, but it just prints |
It needs a few tries in dev mode ... Just Ctrl+R until it works ... Or until you get too bored |
2df9af7
to
aa82f38
Compare
README is now clearer about the fact that it is not really expected to work in dev-builds There are a few other improvements here - so if it works for release builds, we should get this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the original changes + some notes on how build esp-wifi in release always, this LGTM.
This should address the issue reported in #88
Additionally
mkbindings.bat
StaDisconnected
as connected anymore