fix: clippy warnings #1487
Merged
fix: clippy warnings #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federico-terzi
added a commit
that referenced
this pull request
Dec 17, 2023
* fix: clippy warnings (#1426) * fix: bad window style that caused Search bar to crash on macOS ventura #1413 and missed initialization that caused segmentation fault on some cases (#1424) * fix(detect): update sctk version to fix #1057 on wayland Co-authored-by: Ricky Kresslein <rk@lakoliu.com> * chore: bump version * chore(deps): bump regex from 1.4.6 to 1.5.5 (#1428) Bumps [regex](https://github.com/rust-lang/regex) from 1.4.6 to 1.5.5. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.4.6...1.5.5) --- updated-dependencies: - dependency-name: regex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: version bump * fix: clippy warnings (#1487) * fix: clippy warnings * fix: clippy warning * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: cleanup and crate updates (#1602) * update incompatible packages * fix some clippy warnings * fix clippy warnings * update winrt-notification version * fix formatting * fix warning * fix warning * fix: upgrade Rust version in Linux release pipeline * Minor improvements to README (#1581) - Remove trailing spaces - Remove inline HTML * fix: compilation issues and warnings (#1770) * fix some warnings * fix issue * fix: bump rust version on Linux pipelines * chore: bump cargo-deb dependency * chore: refactor CI deployment pipelines (#1771) * chore: refactor CI deployment pipelines * rollback test change * chore(deps): bump webpki from 0.22.0 to 0.22.2 (#1772) Bumps [webpki](https://github.com/briansmith/webpki) from 0.22.0 to 0.22.2. - [Commits](https://github.com/briansmith/webpki/commits) --- updated-dependencies: - dependency-name: webpki dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(core): enable alt-code emulation by default on Windows (#1603) * fix(config): fix warning * fix(config): fix warning * chore(deps): bump openssl from 0.10.36 to 0.10.61 (#1773) Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.36 to 0.10.61. - [Release notes](https://github.com/sfackler/rust-openssl/releases) - [Commits](sfackler/rust-openssl@openssl-v0.10.36...openssl-v0.10.61) --- updated-dependencies: - dependency-name: openssl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: update documentation (#1774) * fix(detect): update sctk dependency to fix crash (#1769) * bump sctk to 16.1 * Update seats type and match statements to match sctk v16 * Improve code quality opting-in some `clippy` pedantic lints (#1775) * 🚨 Change single points of failure for `assert!` * 🐛 Fix a missing `;` * 🚨 Add missing `;` for consistent formatting * 🚨 Fix `{}` with `{variable}` lint * 🚨 Remove redundant else blocks * 🚨 Separate numbers with `_` inbetween * 🚨 Fix unused `&self` argument * 🚨 Fix arg passed by value but not consumed-part 1 * 🚧 Trying to compile linux build * Revert "🚨 Fix arg passed by value but not consumed-part 1" This reverts commit 7c54210. * Revert ":construction: Trying to compile linux build" This reverts commit 617361d. * 🚨 Change redundant closures with std methods * 🚨 Change `for_each()` for `for` cycles * 🚨 Add 2 more of `panic` in `if` statements * 🚨 Change negative if for positive if * 🚨 Fix unnested `or` patterns * 🚨 Add some more `;` * 🚨 Rename `_var` to `var` when it's possible * 🚨 Remove `iter()` in for cycles * 🐛 Fix `keys()` bug * 🚨 Fix `"".to_string()` into `String::new()` * 🚨 Fix `""to_owned()` into `String::new()` * 🚨 Fix clippy and derive `Default` trait * 🚨 Rename `_var` for `var` some more * 🚨 Another block of adding `;` * 🐛 Fix `_` unused var that breaks clippy * 🚨 Fix _some_ star imports * 🚨 Remove unnecessary use of `vec![]` * chore: 📝 Update the path for windows portable compilation (#1782) * feat(core): add label to espanso cli on match (#1720) * refactor(match_cli): update print_matches functions to include label and handle errors * fix formatting * fix types * fix optionality --------- Co-authored-by: Federico Terzi <federico-terzi@users.noreply.github.com> * fix(core): update package dependencies for Debian 12+ and Ubuntu 22.10+ (#1697) Removes '$auto' keyword to support dependencies Fixes #1674 Fixes #1662 * docs: improve description of compilation on Windows (#1785) * chore: 🚨 more `clippy` pedantic lints (#1779) * 🚨 Fix 1 case of 1 if for 1 panic (do `assert!`) * 🚨 Remove unnecessary `mut` * 🚨 Fix `{}` with `{variable}` lint * 🚨 Fix redundant closure * 🚨 Fix `map(<f>).unwrap_or_else(<g>)` * 🚨 Rewrite to `let...else` * 🚨 Remove unnecessary hashes `#` in raw strings * 🚨 Remove useless `for_each` * 🚨 De-reference double referenced values (`&&`) * 🚨 Add ` to documentation * 🚨 A couple of lints * 🚨 Replace `match` with 1 arm for `if let` * 🚨 Change `Default` for `Struct::default()` * 🚨 Change `Ok(_)` with `Ok(())` --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: lakoliu <99976966+lakoliu@users.noreply.github.com> Co-authored-by: Ricky Kresslein <rk@lakoliu.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ashish Bhatia <ashishb@ashishb.net> Co-authored-by: Morgan <morgan.k@skiff.com> Co-authored-by: Auca Coyan <aucacoyan@gmail.com> Co-authored-by: Erwann Mest <m+github@kud.io> Co-authored-by: Rick Calixte <10281587+rcalixte@users.noreply.github.com> Co-authored-by: Nai Hao Cheng <chengnaihao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.