Add label to espanso cli on match #1720

kud · 2023-10-05T22:27:23Z

No description provided.

federico-terzi

Hey @kud, thanks for the contribution!

Before proceeding, we should pull from dev to get the latest CI fixes and make sure everything is running properly. When you get the chance, could you please pull from dev and push? :)

PS: sorry for the late reply!

kud · 2023-12-10T16:26:01Z

Sure thing, thanks!

…and handle errors

kud · 2023-12-11T11:18:01Z

It's done @federico-terzi 😌

federico-terzi · 2023-12-11T11:27:09Z

@kud Thanks! It seems the formatting is off, could you try running cargo fmt on the file you changed? :)

kud · 2023-12-11T11:40:03Z

zsh: command not found: cargo

I think I need your help on this one please :D

Available on Twitter in DM if it's easier.

federico-terzi · 2023-12-13T08:28:36Z

@AucaCoyan Do you think you can help @kud with formatting? :) If not, no worries, I can look at it this weekend

kud · 2023-12-13T11:00:01Z

I will try to install cargo at first and see how it goes 😌

AucaCoyan · 2023-12-13T11:19:52Z

Sure! @kud hit me up in discord or an email if you want some help!
https://discord.gg/DFcCNDg7bB or aucacoyan@gmail.com

federico-terzi · 2023-12-17T08:50:27Z

Thanks folks! Fixed the formatting issue :)

* fix: clippy warnings (#1426) * fix: bad window style that caused Search bar to crash on macOS ventura #1413 and missed initialization that caused segmentation fault on some cases (#1424) * fix(detect): update sctk version to fix #1057 on wayland Co-authored-by: Ricky Kresslein <rk@lakoliu.com> * chore: bump version * chore(deps): bump regex from 1.4.6 to 1.5.5 (#1428) Bumps [regex](https://github.com/rust-lang/regex) from 1.4.6 to 1.5.5. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.4.6...1.5.5) --- updated-dependencies: - dependency-name: regex dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: version bump * fix: clippy warnings (#1487) * fix: clippy warnings * fix: clippy warning * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: clippy warnings * fix: cleanup and crate updates (#1602) * update incompatible packages * fix some clippy warnings * fix clippy warnings * update winrt-notification version * fix formatting * fix warning * fix warning * fix: upgrade Rust version in Linux release pipeline * Minor improvements to README (#1581) - Remove trailing spaces - Remove inline HTML * fix: compilation issues and warnings (#1770) * fix some warnings * fix issue * fix: bump rust version on Linux pipelines * chore: bump cargo-deb dependency * chore: refactor CI deployment pipelines (#1771) * chore: refactor CI deployment pipelines * rollback test change * chore(deps): bump webpki from 0.22.0 to 0.22.2 (#1772) Bumps [webpki](https://github.com/briansmith/webpki) from 0.22.0 to 0.22.2. - [Commits](https://github.com/briansmith/webpki/commits) --- updated-dependencies: - dependency-name: webpki dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(core): enable alt-code emulation by default on Windows (#1603) * fix(config): fix warning * fix(config): fix warning * chore(deps): bump openssl from 0.10.36 to 0.10.61 (#1773) Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.36 to 0.10.61. - [Release notes](https://github.com/sfackler/rust-openssl/releases) - [Commits](sfackler/rust-openssl@openssl-v0.10.36...openssl-v0.10.61) --- updated-dependencies: - dependency-name: openssl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: update documentation (#1774) * fix(detect): update sctk dependency to fix crash (#1769) * bump sctk to 16.1 * Update seats type and match statements to match sctk v16 * Improve code quality opting-in some `clippy` pedantic lints (#1775) * 🚨 Change single points of failure for `assert!` * 🐛 Fix a missing `;` * 🚨 Add missing `;` for consistent formatting * 🚨 Fix `{}` with `{variable}` lint * 🚨 Remove redundant else blocks * 🚨 Separate numbers with `_` inbetween * 🚨 Fix unused `&self` argument * 🚨 Fix arg passed by value but not consumed-part 1 * 🚧 Trying to compile linux build * Revert "🚨 Fix arg passed by value but not consumed-part 1" This reverts commit 7c54210. * Revert ":construction: Trying to compile linux build" This reverts commit 617361d. * 🚨 Change redundant closures with std methods * 🚨 Change `for_each()` for `for` cycles * 🚨 Add 2 more of `panic` in `if` statements * 🚨 Change negative if for positive if * 🚨 Fix unnested `or` patterns * 🚨 Add some more `;` * 🚨 Rename `_var` to `var` when it's possible * 🚨 Remove `iter()` in for cycles * 🐛 Fix `keys()` bug * 🚨 Fix `"".to_string()` into `String::new()` * 🚨 Fix `""to_owned()` into `String::new()` * 🚨 Fix clippy and derive `Default` trait * 🚨 Rename `_var` for `var` some more * 🚨 Another block of adding `;` * 🐛 Fix `_` unused var that breaks clippy * 🚨 Fix _some_ star imports * 🚨 Remove unnecessary use of `vec![]` * chore: 📝 Update the path for windows portable compilation (#1782) * feat(core): add label to espanso cli on match (#1720) * refactor(match_cli): update print_matches functions to include label and handle errors * fix formatting * fix types * fix optionality --------- Co-authored-by: Federico Terzi <federico-terzi@users.noreply.github.com> * fix(core): update package dependencies for Debian 12+ and Ubuntu 22.10+ (#1697) Removes '$auto' keyword to support dependencies Fixes #1674 Fixes #1662 * docs: improve description of compilation on Windows (#1785) * chore: 🚨 more `clippy` pedantic lints (#1779) * 🚨 Fix 1 case of 1 if for 1 panic (do `assert!`) * 🚨 Remove unnecessary `mut` * 🚨 Fix `{}` with `{variable}` lint * 🚨 Fix redundant closure * 🚨 Fix `map(<f>).unwrap_or_else(<g>)` * 🚨 Rewrite to `let...else` * 🚨 Remove unnecessary hashes `#` in raw strings * 🚨 Remove useless `for_each` * 🚨 De-reference double referenced values (`&&`) * 🚨 Add ` to documentation * 🚨 A couple of lints * 🚨 Replace `match` with 1 arm for `if let` * 🚨 Change `Default` for `Struct::default()` * 🚨 Change `Ok(_)` with `Ok(())` --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: lakoliu <99976966+lakoliu@users.noreply.github.com> Co-authored-by: Ricky Kresslein <rk@lakoliu.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ashish Bhatia <ashishb@ashishb.net> Co-authored-by: Morgan <morgan.k@skiff.com> Co-authored-by: Auca Coyan <aucacoyan@gmail.com> Co-authored-by: Erwann Mest <m+github@kud.io> Co-authored-by: Rick Calixte <10281587+rcalixte@users.noreply.github.com> Co-authored-by: Nai Hao Cheng <chengnaihao@gmail.com>

kud · 2023-12-17T13:13:17Z

lovely, thanks!

My first PR 😊

AucaCoyan · 2023-12-17T14:57:49Z

first PR

First of many I hope ! ❤️

kud · 2023-12-18T19:37:17Z

@federico-terzi @AucaCoyan

I don't understand I still have an error.

  - trigger: "??r.okletsgo"
    replace: "https://www.youtube.com/watch?v=AWM5ZNdWlqw"
    label: "Okay Let's Go"

generates

??r.okletsgo - Okay Let's Go - Okay Let's Go

via espanso match list

kud force-pushed the feat/cli-add-label branch from d41c6f4 to 8f13818 Compare October 5, 2023 22:28

kud mentioned this pull request Oct 30, 2023

[Espanso] Copies "Label" field instead of "Replace" field. raycast/extensions#8235

Closed

nbbaier mentioned this pull request Nov 4, 2023

[Espanso]: Add ability to display match labels to Search Matches command raycast/extensions#9101

Merged

5 tasks

AucaCoyan approved these changes Nov 30, 2023

View reviewed changes

federico-terzi reviewed Dec 10, 2023

View reviewed changes

refactor(match_cli): update print_matches functions to include label …

850d0bd

…and handle errors

kud force-pushed the feat/cli-add-label branch from 8f13818 to 850d0bd Compare December 11, 2023 11:17

AucaCoyan self-requested a review December 11, 2023 13:33

federico-terzi added 4 commits December 17, 2023 09:30

fix formatting

51504be

fix merge conflict

d4871be

fix types

1ecb5cb

fix optionality

a617593

federico-terzi merged commit d358f71 into espanso:dev Dec 17, 2023
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add label to espanso cli on match #1720

Add label to espanso cli on match #1720

kud commented Oct 5, 2023

federico-terzi left a comment

kud commented Dec 10, 2023

kud commented Dec 11, 2023

federico-terzi commented Dec 11, 2023

kud commented Dec 11, 2023 •

edited

federico-terzi commented Dec 13, 2023

kud commented Dec 13, 2023

AucaCoyan commented Dec 13, 2023

federico-terzi commented Dec 17, 2023

kud commented Dec 17, 2023

AucaCoyan commented Dec 17, 2023

kud commented Dec 18, 2023

Add label to espanso cli on match #1720

Add label to espanso cli on match #1720

Conversation

kud commented Oct 5, 2023

federico-terzi left a comment

Choose a reason for hiding this comment

kud commented Dec 10, 2023

kud commented Dec 11, 2023

federico-terzi commented Dec 11, 2023

kud commented Dec 11, 2023 • edited

federico-terzi commented Dec 13, 2023

kud commented Dec 13, 2023

AucaCoyan commented Dec 13, 2023

federico-terzi commented Dec 17, 2023

kud commented Dec 17, 2023

AucaCoyan commented Dec 17, 2023

kud commented Dec 18, 2023

kud commented Dec 11, 2023 •

edited