Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SI7021 as a model #132

Closed
wants to merge 34 commits into from
Closed

Adding SI7021 as a model #132

wants to merge 34 commits into from

Conversation

grea09
Copy link
Contributor

@grea09 grea09 commented Jan 21, 2019

Description:

Some one wire versions of SI7021 (distributed by Sonoff for their TH modules) requires a different initialization procedure to work. They use the same protocol as the DHT sensors.

Related issue (if applicable): fixes

Pull request in esphomeyaml with YAML changes (if applicable): esphome/esphome#375
Pull request in esphomelib with C++ framework changes (if applicable): esphome/esphome-core#433

Checklist:

  • The documentation change has been tested and compiles correctly.
  • Branch: next is for changes and new documentation that will go public with the next esphomelib release. Fixes, changes and adjustments for the current release should be created against current.

@OttoWinter OttoWinter changed the base branch from current to next January 25, 2019 16:55
@OttoWinter OttoWinter changed the base branch from next to current January 25, 2019 16:55
@OttoWinter
Copy link
Member

This PR needs to be against the next branch of this repository. Please rebase this commit on top of the next branch and change the PR target to next (by clicking on link below title).

@grea09 grea09 changed the base branch from current to next January 26, 2019 14:34
@grea09
Copy link
Contributor Author

grea09 commented Jan 26, 2019

I'm not an expert on git and branches but I think that will work. I'm sure there's a better way to do the rebase but I don't have time to search for it.

If that's not good I will probably make another PR and close this one.

@OttoWinter
Copy link
Member

Yes this PR still contains commits that are not from here, that needs to be removed. Easiest way is probably to create new PR, but you can also use this guide: https://developers.home-assistant.io/docs/en/development_catching_up.html

@grea09 grea09 changed the base branch from next to current January 28, 2019 10:32
OttoWinter and others added 14 commits January 28, 2019 12:23
ID:s can't have - in the name. Changed it to underscore _
* Added explanation how to change the password

* Update ota.rst

* Use RST syntax
* Update index.rst

* Use modern API
* Add ESP8266 advanced info

* Improve
* Cookbook for Sonoff basic, using cron, toggle button, and sensor connected on GPIO14

* ✏️ Simplify, Formatting

* Pull esphome#122 - file changes noted in comments

* Resized and compressed cookbook image

* Changed cron seconds to 0, this means it will only execute once

* Moved part of documentation to Sonoff Basic under 'More details', removed unused images

* Fixed header numbering

* ✏ Fix cross-references
Actual default update_interval is 60 seconds (measured with stopwatch) over MQTT, not 15 seconds.
Some one wire versions of SI7021 (distributed by Sonoff for their TH modules) requires a different initialization procedure to work. They use the same protocol as the DHT sensors.
@grea09 grea09 changed the base branch from current to next January 28, 2019 11:25
@grea09
Copy link
Contributor Author

grea09 commented Jan 28, 2019

I followed the instructions and I think this is good. I am not sure tho.

If it is not good I will close this PR and open another one. I wanted to learn how to do that properly because it keeps happening 😄

@OttoWinter
Copy link
Member

No this PR still has other commits on here (see files tab). Opening another PR is probably best option.

@grea09 grea09 closed this Feb 2, 2019
@grea09 grea09 deleted the patch-1 branch February 2, 2019 09:35
@grea09 grea09 mentioned this pull request Feb 2, 2019
2 tasks
@esphome esphome locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants