Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standardized CRC helper functions #4798

Merged
merged 14 commits into from Jul 30, 2023
Merged

Add standardized CRC helper functions #4798

merged 14 commits into from Jul 30, 2023

Conversation

Mat931
Copy link
Contributor

@Mat931 Mat931 commented May 9, 2023

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@Mat931 Mat931 marked this pull request as ready for review May 10, 2023 10:32
@probot-esphome
Copy link

Hey there @andreashergert1984, mind taking a look at this pull request as it has been labeled with an integration (pipsolar) you are listed as a code owner for? Thanks!
Hey there @alengwenus, mind taking a look at this pull request as it has been labeled with an integration (sml) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

esphome/core/helpers.cpp Outdated Show resolved Hide resolved
esphome/core/helpers.cpp Outdated Show resolved Hide resolved
esphome/core/helpers.cpp Outdated Show resolved Hide resolved
esphome/core/helpers.cpp Outdated Show resolved Hide resolved
esphome/core/helpers.cpp Outdated Show resolved Hide resolved
esphome/core/helpers.cpp Outdated Show resolved Hide resolved
esphome/core/helpers.cpp Outdated Show resolved Hide resolved
@jesserockz jesserockz enabled auto-merge (squash) July 30, 2023 21:17
@jesserockz jesserockz merged commit 98bf427 into esphome:dev Jul 30, 2023
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
@Mat931 Mat931 deleted the crc branch August 10, 2023 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants