Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folia Support? #52

Open
Fuwayuka opened this issue Apr 29, 2023 · 7 comments
Open

Folia Support? #52

Fuwayuka opened this issue Apr 29, 2023 · 7 comments

Comments

@Fuwayuka
Copy link

Is it possible to make this plugin compatible with Folia?

@Fuwayuka
Copy link
Author

Manual backup was possible by placing folia-supported: true in plugin.yml, but the cron setting did not work as instructed.

@espidev
Copy link
Owner

espidev commented Apr 29, 2023

What is folia?

@Fuwayuka
Copy link
Author

This is a new server from the papermc team.
https://github.com/PaperMC/Folia

@espidev
Copy link
Owner

espidev commented May 10, 2023

Might involve some code changes, but it can be a good idea to support it

@Fuwayuka
Copy link
Author

If you would like to help, please support us.

@espidev
Copy link
Owner

espidev commented May 22, 2023

Perhaps if I have time to do so, otherwise PRs welcome

@Fuwayuka
Copy link
Author

Fuwayuka commented Jul 5, 2023

I can no longer back up using the /ebackup backup command.
Folia 1.20.1.

ebackup backup
[23:36:22 INFO]: Starting backup (check console logs for details)...
[23:36:22 INFO]: [eBackup] Starting backup...
[23:36:23 WARN]: A manual (plugin-induced) save has been detected while server is configured to auto-save. This may affect performance.
[23:36:23 WARN]: [eBackup] Global task for eBackup v1.3.1 generated an exception
java.lang.NullPointerException: Cannot read field "regioniser" because the return value of "io.papermc.paper.threadedregions.TickRegionScheduler.getCurrentRegion()" is null
at io.papermc.paper.chunk.system.scheduling.ChunkHolderManager.saveAllChunksRegionised(ChunkHolderManager.java:337) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at io.papermc.paper.chunk.system.scheduling.ChunkHolderManager.saveAllChunks(ChunkHolderManager.java:331) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at net.minecraft.server.level.ChunkMap.saveAllChunks(ChunkMap.java:496) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at net.minecraft.server.level.ServerChunkCache.save(ServerChunkCache.java:380) ~[?:?]
at net.minecraft.server.level.ServerLevel.save(ServerLevel.java:1462) ~[?:?]
at net.minecraft.server.level.ServerLevel.save(ServerLevel.java:1443) ~[?:?]
at org.bukkit.craftbukkit.v1_20_R1.CraftWorld.save(CraftWorld.java:1266) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at dev.espi.ebackup.BackupUtil.lambda$doBackup$0(BackupUtil.java:122) ~[ebackup-1.3.1.jar:?]
at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftTask.run(CraftTask.java:103) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftScheduler.lambda$handle$3(CraftScheduler.java:566) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at io.papermc.paper.threadedregions.scheduler.FoliaGlobalRegionScheduler$GlobalScheduledTask.run(FoliaGlobalRegionScheduler.java:178) ~[folia-1.20.1.jar:?]
at io.papermc.paper.threadedregions.scheduler.FoliaGlobalRegionScheduler.tick(FoliaGlobalRegionScheduler.java:36) ~[folia-1.20.1.jar:?]
at io.papermc.paper.threadedregions.RegionizedServer.globalTick(RegionizedServer.java:305) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at io.papermc.paper.threadedregions.RegionizedServer$GlobalTickTickHandle.tickRegion(RegionizedServer.java:160) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:388) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.1.jar:git-DirtyFolia-"714b2f9"]
at java.lang.Thread.run(Thread.java:833) ~[?:?]

If I have time, I will send a PR here.
https://github.com/BlockhostOfficial/folia-plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants