Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inclusion of *_hal headers in .cpp files (IDFGH-10573) #11813

Closed
3 tasks done
higaski opened this issue Jul 5, 2023 · 1 comment
Closed
3 tasks done

Allow inclusion of *_hal headers in .cpp files (IDFGH-10573) #11813

higaski opened this issue Jul 5, 2023 · 1 comment
Assignees
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Type: Bug bugs in IDF

Comments

@higaski
Copy link
Contributor

higaski commented Jul 5, 2023

Answers checklist.

  • I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
  • I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.

ESP-IDF v5.2-dev-1349-gcf7e743a9b

Operating System used.

Linux

How did you build your project?

Command line with Make

If you are using Windows, please specify command line type.

None

What is the expected behavior?

Commit 921713f broke a build of mine which relies on one of the low level routines in uart_ll.h
From that commit on the header can no longer be included in a .cpp file because of C++s stronger typing.

/home/vinci/esp/esp-idf/components/hal/esp32s3/include/hal/uart_ll.h:112:27: error: cannot convert 'soc_periph_uart_clk_src_legacy_t' to 'soc_module_clk_t' in assignment
  112 |             *source_clk = UART_SCLK_APB;
      |                           ^~~~~~~~~~~~~
      |                           |
      |                           soc_periph_uart_clk_src_legacy_t
compilation terminated due to -Wfatal-errors.

I'd appreciate it if compatibility could be restored by adding a cast.

What is the actual behavior?

.

Steps to reproduce.

.

Build or installation Logs.

No response

More Information.

No response

@higaski higaski added the Type: Bug bugs in IDF label Jul 5, 2023
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jul 5, 2023
@github-actions github-actions bot changed the title Allow inclusion of *_ll headers in .cpp files Allow inclusion of *_ll headers in .cpp files (IDFGH-10573) Jul 5, 2023
@higaski higaski changed the title Allow inclusion of *_ll headers in .cpp files (IDFGH-10573) Allow inclusion of *_hal headers in .cpp files (IDFGH-10573) Jul 5, 2023
@0xjakob
Copy link
Contributor

0xjakob commented Jul 7, 2023

@higaski Thanks for letting us know! We'll add this cast and come back to you here.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Type: Bug bugs in IDF
Projects
None yet
Development

No branches or pull requests

4 participants