json component contain a test.c file with main function

[niraizik]

The json components contain a cJSON/test.c file that have the main function.
If I have a project with a main function (called in app_main) it may not get called
The json test main will be called instead (it depend on the location of the libs in the LD command)

I think I t is better to exclude test.c in json component.mk

[anujdeshpande]

I understand why that can be frustrating, but cjson is a git submodule in the main esp-idf git repo. If we change the file, we will have to make changes to upstream or maintain our own fork(which is tedious).

It would've been possible to add a src/include directory instead of the whole cjson directory in component.mk but that would still involve making changes upstream.

Do you think you could send a PR to the upstream repo for a fix?

[negativekelvin]

https://esp-idf.readthedocs.io/en/latest/api-guides/build-system.html#specifying-source-files

[niraizik]

Hi @anujdeshpande,
As @negativekelvin add can't we just add
COMPONENT_OBJS := cJSON/cJSON.o cJSON/cJSON_Utils.o
to the json component.mk