Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cmake compilation for OTA (IDFGH-2066) #4198

Closed
wants to merge 1 commit into from

Conversation

copercini
Copy link

In some cases Cmake hits fatal error: esp_ota_ops.h: No such file or directory, this fix this issue

In some cases Cmake hits  fatal error: esp_ota_ops.h: No such file or directory, this fix this issue
Copy link
Contributor

@projectgus projectgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copercini Thanks for noticing and sending this in!

components/esp_https_ota/CMakeLists.txt Show resolved Hide resolved
@mahavirj
Copy link
Member

@copercini

In some cases Cmake hits fatal error: esp_ota_ops.h: No such file or directory, this fix this issue

Under what cases do you see this error? Current dependency of app_update component PRIV_REQUIRES should be sufficient, per its public interface.

@github-actions github-actions bot changed the title Fix Cmake compilation for OTA Fix Cmake compilation for OTA (IDFGH-2066) Oct 25, 2019
@mahavirj
Copy link
Member

mahavirj commented Nov 4, 2019

We have done some changes to this PR (as per suggestions and also some internal discussions) and put up in internal merge queue.

@mahavirj mahavirj self-assigned this Nov 4, 2019
espressif-bot pushed a commit that referenced this pull request Jan 24, 2020
components/esp_https_ota: Changes in public requirement list for CMake and esp_ota_ops.h is included in esp_https_ota.c

bootloader_support is added in public requirements of CMake

bootloader_common.h is included in esp_https_ota.h

Closes #4198

Closes IDFGH-2066
espressif-bot pushed a commit that referenced this pull request Mar 23, 2020
components/esp_https_ota: Changes in public requirement list for CMake and esp_ota_ops.h is included in esp_https_ota.c

bootloader_support is added in public requirements of CMake

bootloader_common.h is included in esp_https_ota.h

Closes #4198

Closes IDFGH-2066
jack0c pushed a commit that referenced this pull request Jul 29, 2020
components/esp_https_ota: Changes in public requirement list for CMake and esp_ota_ops.h is included in esp_https_ota.c

bootloader_support is added in public requirements of CMake

bootloader_common.h is included in esp_https_ota.h

Closes #4198

Closes IDFGH-2066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants