Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TW#12969] AWS-IOT advanced configuration (change AWS_IOT_MQTT_TX_BUF_LEN) #637

Closed
Vlad-Iliescu opened this issue May 23, 2017 · 9 comments
Assignees

Comments

@Vlad-Iliescu
Copy link

Recently working on an aws-iot client I had the need to increase the AWS_IOT_MQTT_TX_BUF_LEN. The only way I found to increase this was by editing the file aws_iot_config.h. However I find this not being the best way since on the next esp-idf update this will get overwritten.

Is there another safe way to increase this without having to edit the component itself.

@mkonnov
Copy link

mkonnov commented May 23, 2017

I have changed it the same way. It's not overwriting. Refer to git basics.

"aws-iot-device-sdk-embedded-C" is a separate submodule. It means that bringing this setting into menuconfig (even when it seems more reasonable than direct file changing) will require change this file by esp-idf devs. Which means it must be forked or copied into a project (as FreeRTOS, for example).

@Smeedy
Copy link

Smeedy commented May 23, 2017

Also ran into this one. So you are saying that the only way right now is to change it in the submodule? Indeed, this does work, but it is a bit of a crude solution. Why doesn't an #undef and again #define should cope with this? Couldn't make this happen and indeed had to revert to changing the submodule itself.

@mkonnov
Copy link

mkonnov commented May 23, 2017

I'm not saying about the only right way.
And I forgot about #undef so the solution you proposed is better.

@Smeedy
Copy link

Smeedy commented May 23, 2017

I was not making myself clear. I /tried/ the #undef/#def, but this fails and I'm stuck with the original values. So I also reverted to altering the config.h.

@mkonnov
Copy link

mkonnov commented May 23, 2017

Get you.
I just noticed that I was wrong regarding the submodule.
aws_iot_config.h is not the part of "aws-iot-device-sdk-embedded-C" submodule, so it can be changed to be configured from themenuconfig.

@knap1930
Copy link

even if it were in the aws-iot-device-sdk-embedded-C submodule, it has already been cloned...

https://github.com/espressif/aws-iot-device-sdk-embedded-C/

@mkonnov
Copy link

mkonnov commented May 24, 2017

This is just some repo that's have nothing common with 'esp-idf'.
I could copy it in my profile and say the same.

@knap1930
Copy link

knap1930 commented May 24, 2017

Not true, take a look at https://github.com/espressif/esp-idf/tree/master/components/aws_iot

Notice the submodule is pointing at https://github.com/espressif/aws-iot-device-sdk-embedded-C/tree/7132505b00d2dd57f48478e75efa636021919aae

Espressif has cloned the AWS repo, made some changes, and pointed the submodule to their clone.

@mkonnov
Copy link

mkonnov commented May 24, 2017

I didn't notice that.
Thanks for explanation.

@FayeY FayeY closed this as completed May 31, 2017
@projectgus projectgus reopened this May 31, 2017
@projectgus projectgus self-assigned this May 31, 2017
@FayeY FayeY changed the title AWS-IOT advanced configuration (change AWS_IOT_MQTT_TX_BUF_LEN) [TW#12969] AWS-IOT advanced configuration (change AWS_IOT_MQTT_TX_BUF_LEN) May 31, 2017
@igrr igrr closed this as completed in eeb8dc9 Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants