Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in HCD pipe alloc, should be BULK not ISO (IDFGH-5228) #7000

Closed
chipweinberger opened this issue May 9, 2021 · 2 comments
Closed

Bug in HCD pipe alloc, should be BULK not ISO (IDFGH-5228) #7000

chipweinberger opened this issue May 9, 2021 · 2 comments
Assignees
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@chipweinberger
Copy link
Contributor


esp_err_t hcd_pipe_alloc(hcd_port_handle_t port_hdl, const hcd_pipe_config_t *pipe_config, hcd_pipe_handle_t *pipe_hdl)
{
....
    switch (type) {
        case USB_XFER_TYPE_CTRL:
            hal_type = USB_PRIV_XFER_TYPE_CTRL;
            break;
        case USB_XFER_TYPE_ISOCHRONOUS:
            hal_type = USB_PRIV_XFER_TYPE_ISOCHRONOUS;
            break;
        case USB_XFER_TYPE_BULK:
            hal_type = USB_PRIV_XFER_TYPE_ISOCHRONOUS; //BUG! Should be USB_PRIV_XFER_TYPE_BULK
            break;
        default:    //USB_XFER_TYPE_INTR
            hal_type = USB_PRIV_XFER_TYPE_INTR;
            break;
    }

See above. There is a clear copy past bug for USB_XFER_TYPE_BULK.

link: https://github.com/espressif/esp-idf/blob/9d34a1cd42f6f63b3c699c3fe8ec7216dd56f36a/components/usb/hcd.c

@espressif-bot espressif-bot added the Status: Opened Issue is new label May 9, 2021
@github-actions github-actions bot changed the title Bug in HCD pipe alloc, should be BULK not ISO Bug in HCD pipe alloc, should be BULK not ISO (IDFGH-5228) May 9, 2021
@chegewara
Copy link
Contributor

#6887 (comment)

@Dazza0 Dazza0 self-assigned this Jun 8, 2021
@Dazza0
Copy link
Contributor

Dazza0 commented Jun 8, 2021

Closed by 7f42104

@Dazza0 Dazza0 closed this as completed Jun 8, 2021
@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: Opened Issue is new labels Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

4 participants