Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same sense of meaning SW_STRAP #367

Closed
wants to merge 1 commit into from
Closed

Same sense of meaning SW_STRAP #367

wants to merge 1 commit into from

Conversation

ESP32DE
Copy link
Contributor

@ESP32DE ESP32DE commented Feb 21, 2017

No description provided.

@negativekelvin
Copy link
Contributor

Separate commits and separate pull requests!?

@ESP32DE
Copy link
Contributor Author

ESP32DE commented Feb 21, 2017

;-) sry
was my mistake.
want make one pull request with 2 edit files.
but could not add the second edit to the other file to the one pull request

Still has to practice pull request

best wishes
rudi ;-)

@projectgus projectgus added the Status: Pending blocked by some other factor label Mar 2, 2017
@projectgus
Copy link
Contributor

Thanks for this, Rudi. I've squashed this commit with the one from #366 and added them to our internal review & merge queue.

igrr pushed a commit that referenced this pull request Mar 6, 2017
@ESP32DE @projectgus
examples/ethernet: Same sense of meaning SW_STRAP
f4c4787 
Merges #366 #367
#366
#367
igrr pushed a commit that referenced this pull request Mar 6, 2017
@projectgus
Merge branch 'bugfix/github_small_fixes' into 'master'
975be7a 
Merge small bugfix PRs from github

* #389
* #382
* #367
* #366
* #361
* #355
* #350
* #348
* #339
* #46
* #307



See merge request !541
@projectgus
Copy link
Contributor

Cherry-picked in f4c4787, thanks again!

@projectgus projectgus closed this Mar 7, 2017
igrr pushed a commit that referenced this pull request Mar 20, 2017
@ESP32DE @projectgus
examples/ethernet: Same sense of meaning SW_STRAP
de46167 
Merges #366 #367
#366
#367
@igrr igrr removed the Status: Pending blocked by some other factor label Apr 12, 2017
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this pull request May 5, 2021
@mangobuge @me-no-dev
add support for widora-air board (espressif#367)
7b63f58 
* add support for widora-air board

* change widora-air f_cpu error,from 400M to 240M
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ESP32DE @negativekelvin @projectgus @igrr