Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component/bt: fix bug where uuid was not reset in btc_gatts_act_create_attr_tab #307

Closed
wants to merge 2 commits into from
Closed

component/bt: fix bug where uuid was not reset in btc_gatts_act_create_attr_tab #307

wants to merge 2 commits into from

Conversation

Derrrk
Copy link
Contributor

@Derrrk Derrrk commented Jan 28, 2017

This bug happens if you try and create an attribute table with UUID != ESP_UUID_LEN_16 (eg. with ESP_UUID_LEN_128). The uuid is set at the beginning of the loop if UUID == ESP_UUID_LEN_16, but will not be reset on the next iteration.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TianHao-Yoursmake
Copy link

Yeah, It is a bug. Thanks for fix it.

@projectgus projectgus added the Status: Pending blocked by some other factor label Mar 2, 2017
@projectgus
Copy link
Contributor

Thanks for this @Derrrk , and sorry for the slow reply. This has been squashed and added to our internal review/merge queue.

igrr pushed a commit that referenced this pull request Mar 6, 2017
@Derrrk @projectgus
component/bt: fix bug where uuid was not reset in btc_gatts_act_creat…
a4a7900 
…e_attr_tab.

Merges #307 #307
igrr pushed a commit that referenced this pull request Mar 6, 2017
@projectgus
Merge branch 'bugfix/github_small_fixes' into 'master'
975be7a 
Merge small bugfix PRs from github

* #389
* #382
* #367
* #366
* #361
* #355
* #350
* #348
* #339
* #46
* #307



See merge request !541
@projectgus
Copy link
Contributor

Cherry-picked in a4a7900. Thanks!

@projectgus projectgus closed this Mar 7, 2017
igrr pushed a commit that referenced this pull request Mar 20, 2017
@Derrrk @projectgus
component/bt: fix bug where uuid was not reset in btc_gatts_act_creat…
6bb1367 
…e_attr_tab.

Merges #307 #307
@igrr igrr removed the Status: Pending blocked by some other factor label Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Derrrk @CLAassistant @TianHao-Yoursmake @projectgus @igrr