Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: ble_adv data truncation #389

Closed
wants to merge 1 commit into from
Closed

Fixed: ble_adv data truncation #389

wants to merge 1 commit into from

Conversation

lucashutchinson
Copy link
Contributor

Fixed issue with ble_adv data being truncated after the 31st octet due to an incorrect length passed in a memcpy.

Fixes: #369

@lucashutchinson
Fixed: ble_adv data truncation
7e5a433 
Fixed issue with ble_adv data being truncated after the 31st octet due to an incorrect length passed in a memcpy.
@CLAassistant
Copy link

CLAassistant commented Mar 2, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@projectgus
Copy link
Contributor

Thanks very much for this, @lucashutchinson . I've cherry-picked this into our internal review & merge queue, with a small tweak (used sizeof(param.scan_rst.ble_adv) instead of ESP_BLE_ADV_DATA_LEN_MAX + ESP_BLE_SCAN_RSP_DATA_LEN_MAX)

@projectgus projectgus added the Status: Pending blocked by some other factor label Mar 2, 2017
igrr pushed a commit that referenced this pull request Mar 6, 2017
@lucashutchinson @projectgus
ble: Fix ble_adv data truncation
8ce94d5 
Fixed issue with ble_adv data being truncated after the 31st octet due to an incorrect length passed in a memcpy.

Merges #389 #389
igrr pushed a commit that referenced this pull request Mar 6, 2017
@projectgus
Merge branch 'bugfix/github_small_fixes' into 'master'
975be7a 
Merge small bugfix PRs from github

* #389
* #382
* #367
* #366
* #361
* #355
* #350
* #348
* #339
* #46
* #307



See merge request !541
@projectgus
Copy link
Contributor

Cherry-picked as 8ce94d5. Thanks again!

@projectgus projectgus closed this Mar 7, 2017
igrr pushed a commit that referenced this pull request Mar 20, 2017
@lucashutchinson @projectgus
ble: Fix ble_adv data truncation
a286846 
Fixed issue with ble_adv data being truncated after the 31st octet due to an incorrect length passed in a memcpy.

Merges #389 #389
@igrr igrr removed the Status: Pending blocked by some other factor label Apr 12, 2017
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this pull request May 5, 2021
@bbx10 @me-no-dev
Remote tcp disconnect not detected (espressif#389)
06a76ee 
* Add setNoDelay and getNoDelay to WiFiServer class

* Remote TCP disconnect not detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lucashutchinson @CLAassistant @projectgus @igrr