Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electrodes tutorial is unstable #4850

Closed
jngrad opened this issue Jan 15, 2024 · 5 comments · Fixed by #4894
Closed

Electrodes tutorial is unstable #4850

jngrad opened this issue Jan 15, 2024 · 5 comments · Fixed by #4894
Assignees
Labels

Comments

@jngrad
Copy link
Member

jngrad commented Jan 15, 2024

The issue reported in #4798 is still present, and causes CI to fail once per month. See for example pipelines 358223 issue (#4844) and 359158 (issue #4849). The error message shows a different particle position, suggesting the tutorial isn't fully deterministic.

@jngrad
Copy link
Member Author

jngrad commented Jan 30, 2024

@schlaicha @keerthirk1995 any progress from your side? This is still a problem for our CI: pipeline 359192 (issue #4851).

@schlaicha
Copy link
Contributor

I won't be able look into this in the coming weeks again. @keerthirk1995 could you have a look at what is the non-deterministic part?
I assume it is the steepest descent which can behave differently.
So here is what I would try:

  • do the steepest descent as done now
  • as this might still end up in a very unfavourable configuration add some warm-up steps in a loop with the langevin friction set significantly higher (~1?):
    • start with a small timestep, like 0.001
    • run ~200-1000 steps
    • increse timestep (0.002, 0.005, 0.01, ...) until you reach the simulation timestep
  • then, reduce the langevin friction again to enhance diffusion/equilibration

The number of integration steps and timestep increment needs to be adjusted a little...
Let me know if you have questions!

@jngrad
Copy link
Member Author

jngrad commented Feb 2, 2024

Tutorial part 1 is now failing too: pipeline 359826 (issue #4857).

@jngrad
Copy link
Member Author

jngrad commented Feb 12, 2024

pipeline 360162 (issue #4862)

@jngrad
Copy link
Member Author

jngrad commented Mar 28, 2024

This issue has paralyzed the ESPResSo project for a month. The issue tracker was flooded with notifications about this tutorial failing CI. We didn't detect in time an issue from an Ubuntu update on the CI runners because its notifications were drowned in the tutorial notifications, and now all CI runners have an Ubuntu version where the ASAN library is broken. The last merge commit on the python branch at the time of writing is 7ad0534, timestamped a month ago, because we cannot merge a PR if CI is failing, and CI was failing daily due to both ASAN and the tutorial being broken.

@kodiakhq kodiakhq bot closed this as completed in #4894 Mar 28, 2024
kodiakhq bot added a commit that referenced this issue Mar 28, 2024
Fixes #4850

Closes #4849 Closes #4851 Closes #4857 Closes #4860 Closes #4862 Closes #4861 Closes #4863 Closes #4865
Closes #4868 Closes #4869 Closes #4871 Closes #4873 Closes #4875 Closes #4876 Closes #4877 Closes #4878
Closes #4879 Closes #4880 Closes #4881 Closes #4882 Closes #4883 Closes #4885 Closes #4886 Closes #4887
Closes #4888 Closes #4889 Closes #4890 Closes #4891 Closes #4892 Closes #4893 Closes #4895 Closes #4896

Description of changes:
- fix particle crossing the ELC gap in the electrodes tutorial
- disable ASAN checks due to broken dependencies on the host machines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants