Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: adding check for particle existence. #2151

Merged
merged 7 commits into from
Aug 15, 2018

Conversation

KaiSzuttor
Copy link
Member

Fixes #2150

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #2151 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2151    +/-   ##
=======================================
+ Coverage      67%     67%   +<1%     
=======================================
  Files         446     446            
  Lines       30095   30093     -2     
=======================================
+ Hits        20284   20288     +4     
+ Misses       9811    9805     -6
Impacted Files Coverage Δ
src/core/particle_data.cpp 91% <ø> (-1%) ⬇️
src/core/communication.cpp 74% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 338abf0...918f22d. Read the comment docs.

int get_particle_node(int id)
int get_particle_node(int id) except +

particle& get_particle_data(int id) except +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be const &.

@KaiSzuttor
Copy link
Member Author

hm... dejavu... we need cython 0.26 for this to work

@fweik
Copy link
Contributor

fweik commented Aug 15, 2018

You can just remove the data member and call get_particle_data in the getters. That is the cleaner solution anyway

@KaiSzuttor KaiSzuttor merged commit fed5448 into espressomd:python Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants