-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: adding check for particle existence. #2151
Conversation
Codecov Report
@@ Coverage Diff @@
## python #2151 +/- ##
=======================================
+ Coverage 67% 67% +<1%
=======================================
Files 446 446
Lines 30095 30093 -2
=======================================
+ Hits 20284 20288 +4
+ Misses 9811 9805 -6
Continue to review full report at Codecov.
|
int get_particle_node(int id) | ||
int get_particle_node(int id) except + | ||
|
||
particle& get_particle_data(int id) except + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be const &
.
hm... dejavu... we need cython 0.26 for this to work |
You can just remove the data member and call |
Fixes #2150