Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Floor Filter Component] Exposing sites, facilities and levels read-only info. #271

Closed
mansibarodia10057 opened this issue Mar 7, 2023 · 3 comments
Assignees
Labels
Priority - medium A medium-priority item

Comments

@mansibarodia10057
Copy link

mansibarodia10057 commented Mar 7, 2023

Currently there is no way of getting sites, facilities and levels info from floor filter, especially the selected site, selected facility and selected level info. Consuming apps will need this info to keep a track of user's location if the app deals with location related functionality.

Looking at the current floor filter toolkit code, looks like floor filter view model has all the selection details, but the properties are private. These details can be read-only when exposed.

Please allow access to the details of the sites, facilities and levels in the map especially selected site, selected facility and selected level since other details can also be obtained from floor manager.

@dfeinzimer - FYI.

@mansibarodia10057 mansibarodia10057 changed the title [Floor filter toolkit] Exposing sites, facilities and levels read-only info. [Floor Filter Component] Exposing sites, facilities and levels read-only info. Mar 8, 2023
@mhdostal mhdostal added the Priority - medium A medium-priority item label Mar 14, 2023
@dfeinzimer dfeinzimer self-assigned this Mar 22, 2023
@dfeinzimer
Copy link
Collaborator

Please allow access to the details of the sites, facilities and levels in the map especially selected site, selected facility and selected level since other details can also be obtained from floor manager.

Hi @mansibarodia10057. As you said, since the sites, facilities, and levels are accessible through the floor manager and the floor manager is needed to initialize the tool itself, it seems that providing access to these properties would be redundant. Are you okay if we do not include this as apart of resolving this issue?

@mansibarodia10057
Copy link
Author

Please allow access to the details of the sites, facilities and levels in the map especially selected site, selected facility and selected level since other details can also be obtained from floor manager.

Hi @mansibarodia10057. As you said, since the sites, facilities, and levels are accessible through the floor manager and the floor manager is needed to initialize the tool itself, it seems that providing access to these properties would be redundant. Are you okay if we do not include this as apart of resolving this issue?

@dfeinzimer - Yes access to all sites, facilities and levels via floor filter can be skipped. Mainly need access to selected level, facility, site. Selected vertical order would be required as well, but can access it from selected level object.

@dfeinzimer
Copy link
Collaborator

dfeinzimer commented Mar 22, 2023

Yes access to all sites, facilities and levels via floor filter can be skipped. Mainly need access to selected level, facility, site. Selected vertical order would be required as well, but can access it from selected level object.

Great, thank you. Happy to report this is in progress now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - medium A medium-priority item
Projects
None yet
Development

No branches or pull requests

3 participants