Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floor Filter additional changes #40

Closed
10 tasks done
dfeinzimer opened this issue Apr 5, 2022 · 1 comment
Closed
10 tasks done

Floor Filter additional changes #40

dfeinzimer opened this issue Apr 5, 2022 · 1 comment
Assignees
@dfeinzimer
Labels
enhancement New feature or request

Comments

@dfeinzimer
Copy link
Collaborator

dfeinzimer commented Apr 5, 2022 •
edited
Loading

The following are additional items to consider for the Floor Filter following initial feedback on FF_III PR #36 or in a potential new FF_IV PR.

  • Improve on level name truncation.
  • Experiment with increased width of the site/facility picker to avoid title truncation.
  • In compact environments, switch the site/facility picker to be a sheet, (halfscreen preferred).
  • Switch search bars to .searchable
  • Change facility names to a common button style
  • Improve tests
  • Switch .navigationBarItems to .toolbar as it's deprecated
  • Switchover to new sample map with fictional sites and facilites
  • Switch level picker collapse button to a downward chevron
  • All sites button: use a toolbar at the bottom to get the blurring. (Skipped for now due to SwiftUI bug)
@dfeinzimer dfeinzimer added the enhancement New feature or request label Apr 5, 2022
@dfeinzimer dfeinzimer self-assigned this Apr 5, 2022
@dfeinzimer dfeinzimer mentioned this issue Apr 15, 2022
Merged
@dfeinzimer
Copy link
Collaborator Author

Closing, Floor Filter is complete as of #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfeinzimer dfeinzimer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfeinzimer