Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing !defaults in _variables.scss #272

Closed
dbouwman opened this issue Jun 3, 2016 · 0 comments · Fixed by #273
Closed

Missing !defaults in _variables.scss #272

dbouwman opened this issue Jun 3, 2016 · 0 comments · Fixed by #273
Assignees
@TheBlueDog
Labels
bug

Comments

@dbouwman
Copy link
Member

dbouwman commented Jun 3, 2016

There are still some variables in _variables.scss which do not have !default, which basically prevents overriding the values.

Specifically (and I will submit a PR for this specifically) $footer-height --> https://github.com/Esri/calcite-bootstrap/blob/master/lib/sass/calcite/_variables.scss#L898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBlueDog TheBlueDog

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds !default to _variables.scss where missing Esri/calcite-bootstrap
2 participants
@dbouwman @TheBlueDog