-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing CSS and JS files? #296
Comments
Ping @FelFly |
@bsvensson Yes. We did remove them because this project is no longer running a full instance of Bootstrap and I needed the gh-pages branch to write updated documentation (which I should have sometime this week.) Full story here: #294. If you have a copy of the javascript files and want to make a PR to add them to the assets folders of the docs like we did for umacgillivray with the CSS files, we can probably add that as a holdover for the old version of this project. But moving forward, I'm trying to make this into an actual theme that you use on top of the vanilla Bootstrap code - that way folks can have Calcite Bootstrap or customer themes applied and without running two sets of Bootstrap files. |
@klara it would also be helpful if you can write an example of how the library should be used. Show loading bootstrap and then calcite theme.
It might also be helpful to have a "merged version" so it's a single HTTP load
|
@ajturner Yes. I have all this written in the calcite-bootstrap-theme repo. I just need to move it over here. As for a merged version - I don't know what you mean. If you mean that we should have a set of Bootstrap files in this project, I was specifically told by three people in two teams that was the incorrect way to handle a theme and I should remedy it with this version. With this version, there are three paths to running this theme:
|
It seems to me that the consuming app's build process should produce a single css file that is bootstrap + calcite bootstrap + any other css the app needs. |
Let's presume that most people who create websites don't have a "build process" - instead they "edit HTML and JS files". And it may even be a static website <gasp>
My assumption is that describes most "Devs". Just try showing any new dev how to start a new project and do builds.
Regardless, we need some "step-by-step" docs in the README for someone who is building a simple, static website.
|
It seems like https://esri.github.io/calcite-bootstrap/assets/css/calcite-bootstrap-open.min.css and https://esri.github.io/calcite-bootstrap/assets/js/bootstrap.min.js disappeared recently.
Are there new URLs/locations for these? (Or should we not use them?)
The text was updated successfully, but these errors were encountered: