Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CSS and JS files? #296

Open
bsvensson opened this issue Sep 1, 2017 · 6 comments
Open

Missing CSS and JS files? #296

bsvensson opened this issue Sep 1, 2017 · 6 comments

Comments

@bsvensson
Copy link
Member

It seems like https://esri.github.io/calcite-bootstrap/assets/css/calcite-bootstrap-open.min.css and https://esri.github.io/calcite-bootstrap/assets/js/bootstrap.min.js disappeared recently.

Are there new URLs/locations for these? (Or should we not use them?)

@ajturner
Copy link
Member

ajturner commented Sep 4, 2017

Ping @FelFly

@FelFly
Copy link
Collaborator

FelFly commented Sep 5, 2017

@bsvensson Yes. We did remove them because this project is no longer running a full instance of Bootstrap and I needed the gh-pages branch to write updated documentation (which I should have sometime this week.) Full story here: #294.

If you have a copy of the javascript files and want to make a PR to add them to the assets folders of the docs like we did for umacgillivray with the CSS files, we can probably add that as a holdover for the old version of this project.

But moving forward, I'm trying to make this into an actual theme that you use on top of the vanilla Bootstrap code - that way folks can have Calcite Bootstrap or customer themes applied and without running two sets of Bootstrap files.

@ajturner
Copy link
Member

ajturner commented Sep 5, 2017 via email

@FelFly
Copy link
Collaborator

FelFly commented Sep 5, 2017

@ajturner Yes. I have all this written in the calcite-bootstrap-theme repo. I just need to move it over here.

As for a merged version - I don't know what you mean. If you mean that we should have a set of Bootstrap files in this project, I was specifically told by three people in two teams that was the incorrect way to handle a theme and I should remedy it with this version. With this version, there are three paths to running this theme:

  1. Run Calcite Bootstrap as strictly Bootstrap variables
  2. Run Calcite Bootstrap as Bootstrap variables + expansion variables/CSS to achieve stricter Calcite Web "look" and to have support for card components
  3. Run either one of the patterns above, but in the event of a shared theme or customer theme, use that instead

@mjuniper
Copy link
Member

mjuniper commented Sep 5, 2017

It seems to me that the consuming app's build process should produce a single css file that is bootstrap + calcite bootstrap + any other css the app needs.

@ajturner
Copy link
Member

ajturner commented Sep 6, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants