You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry if this is wrong place to mention this but I ran into issue using Dojo Bootstrap (Dropdown.js) and noticed that the version in this repo has a fix:
Line 55
// Fix for not setting dropdown target
if (target.length < 1) {
target = [e.target.parentElement];
}
Should this not be submitted as a pull request to the Dojo Bootstrap project?
The text was updated successfully, but these errors were encountered:
Well you can but I didn't subclass the project because it looked fairly inactive. I had to fix some other stuff as well so I can take the PR here as I maintain a version of the library with this project.
I think that would be interesting to update the project because now we cannot install dojo-bootstrap with bower as the version does not contain the fix. Or maybe the bower depedency should be removed to avoid confusion ?
Sorry if this is wrong place to mention this but I ran into issue using Dojo Bootstrap (Dropdown.js) and noticed that the version in this repo has a fix:
Line 55
// Fix for not setting dropdown target
if (target.length < 1) {
target = [e.target.parentElement];
}
Should this not be submitted as a pull request to the Dojo Bootstrap project?
The text was updated successfully, but these errors were encountered: