Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown.js Fix #122

Closed
RyanBosley opened this issue Jul 8, 2016 · 2 comments
Closed

Dropdown.js Fix #122

RyanBosley opened this issue Jul 8, 2016 · 2 comments

Comments

@RyanBosley
Copy link

Sorry if this is wrong place to mention this but I ran into issue using Dojo Bootstrap (Dropdown.js) and noticed that the version in this repo has a fix:

Line 55
// Fix for not setting dropdown target
if (target.length < 1) {
target = [e.target.parentElement];
}

Should this not be submitted as a pull request to the Dojo Bootstrap project?

@alaframboise
Copy link
Contributor

Well you can but I didn't subclass the project because it looked fairly inactive. I had to fix some other stuff as well so I can take the PR here as I maintain a version of the library with this project.

@Biboba
Copy link

Biboba commented Feb 8, 2017

I think that would be interesting to update the project because now we cannot install dojo-bootstrap with bower as the version does not contain the fix. Or maybe the bower depedency should be removed to avoid confusion ?

Cheers for this nice framework,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants