Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove app secrets from versioned source code #229

Closed
jf990 opened this issue Mar 27, 2020 · 0 comments · Fixed by #250
Closed

remove app secrets from versioned source code #229

jf990 opened this issue Mar 27, 2020 · 0 comments · Fixed by #250
Assignees
@esreli

Comments

@jf990
Copy link
Contributor

jf990 commented Mar 27, 2020

Regarding https://github.com/Esri/data-collection-ios/blob/master/data-collection/data-collection/AppConfiguration.swift#L66

licenseKey and clientID should not be managed in AppConfiguration.swift, as a developer would never want to include these values in source control. Suggesting an app configuration this way would not be considered a best practice.

We should also remove our clientID from source as a hacker could use it to deploy an app. Or consider using a rate limited proxy instead.
@esreli esreli mentioned this issue Jul 1, 2020
Closed
@esreli esreli self-assigned this Jul 1, 2020
@esreli esreli mentioned this issue Jul 21, 2020
Closed
@esreli esreli mentioned this issue Aug 13, 2020
Merged
@esreli esreli linked a pull request Aug 18, 2020 that will close this issue
App Secrets, Attempt no.3 #250
Merged
@esreli esreli closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esreli esreli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

App Secrets, Attempt no.3 Esri/data-collection-ios
Hotfix: App Secrets Esri/data-collection-ios
2 participants
@jf990 @esreli