ESM #83
ESM #83
Conversation
…unignore `.eslintrc.js`;
use "js" extension for comments; enforce `semi` rule; lint `parser.js` to catch any buggy generator issues
- Linting (package.json): Add recommended fields (contributors, bugs, homepage); update repository URL
- Refactoring: Fix broken or redundant HTML
- Maintenance: Enforce 2 sp. for JSON in `.editorconfig` (per current `package.json`)
- npm: Add build scripts (leading currently to Makefile)
- Refactoring: remove now unneed Array.isArray polyfill - npm: Update estraverse dep. minor version and devDeps.
…ull` for `?`) - npm: Add npm scripts in place of Makefile (and remove `parser.js` upon running the parser build) - npm: Simplify to reference binary without `node_modules`
- Refactoring: Switch to ESM internally - Build: Ensure `dist` files are bundled in npm
|
I believe this build is failing as |
|
This generally LGTM. |
|
@brettz9 Rollup seems to be choking on default parameters. Does it need some configuration to support modern syntax? |
|
Sorry, the issue there is with our using such syntax on an older version of Node. I can change the syntax, but if you are open to the breaking change on the Mocha PR, it will remove those travis versions anyways. |
|
However, if you like, I should be able to get it working for Node 4/6 in this PR, and just amend the syntax in the Mocha PR. |
|
I tried amending my usage of Rollup, but I see Rollup itself is internally using default params. :-) . So I can either see about using an older version of Rollup, or if you are ok with the breaking change to require Node 8 (as in my Mocha PR also), I can just drop those versions in Travis in this PR. |
|
Yeah node 4/6 are effectively as old as the other ancient ones we dropped in your earlier PRs. I'll remove them from the travis config and get this merged. |
Builds on #81 and #82.
moduledistfiles are bundled in npmBesides being a preparation for supporting Node ESM (this is aimed at browser ESM), using ESM will assist a proposed conversion to Mocha + nyc for coverage (since there seems no longer a need for specialized
definetesting).